Scheduler Component: reduce executeScheduleRunTask's read critical section #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Sep 27, 2024
Comment on lines
+181
to
+191
| // Ensure that this is copy, so later (stateful) processing does not update state machine without protection | ||
| s = Scheduler{ | ||
| HsmSchedulerState: common.CloneProto(prevS.HsmSchedulerState), | ||
| cspec: prevS.cspec, | ||
| } | ||
|
|
||
| // Copy the list of current running workflows so we can tell later which ones are newly started | ||
| prevRunningWorkflows = make([]*commonpb.WorkflowExecution, len(prevS.Args.Info.RunningWorkflows)) | ||
| for i := 0; i < len(prevS.Args.Info.RunningWorkflows); i++ { | ||
| prevRunningWorkflows[i] = prevS.Args.Info.RunningWorkflows[i] | ||
| } |
There was a problem hiding this comment.
You should clone while holding the lock otherwise the struct may be mutated concurrently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
env.Accessread critical section in the new scheduler's run task.Why?
MachineDataonly ever returns deserialized copies of nodes. Any other thread writing to the HSM's node will be written by serializing a new blob inMachineTransition, and updating the node's internal cache to point to that new blob.How did you test it?
make unit-testPotential risks
Documentation
no
Is hotfix candidate?
no