Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Workflow docs editing #6571
Update Workflow docs editing #6571
Changes from 1 commit
67ed1a5
42db109
1334f5e
2483b17
2bad4ba
a9c5c81
4db433c
ac67c2e
34498db
82c632b
9bd30e5
fd63e53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are only two timeout types for any WFT. My intent here was to emphasize that only one type of timer tasks (
WorkflowTaskTimeoutTask
) is supported which enforce both timeouts. In your version, it sounds like normal WFT has other timeouts but for speculative we have only these 2.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the other timeout type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For activity tasks there is also
SCHEDULE_TO_CLOSE
which is for all attempts. WFT doesn't have it, it is getting retried forever.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha! Changed it to this now:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is important to indicate that this field is not currently used at all. Yes, from your version it kinda implies that, but I would like to see clear sentence saying "it doesn't work this way".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found the "not used part" confusing. It sounds like the worker isn't using the field? I've updated the text now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Yes,
event_id
is set by server and respected by all SDK. It just set not to intended value.command_index
though is indeed not used at all: it is not set by SDKs (at least go) and not checked by server.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense 👍