Skip nexus events from reapplication when excluded #6598
+131
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
When nexus events are explicitly excluded we skip them from reapplication.
Why?
We want an option to completely exclude reapplication of all events past reset point. Currently certain HSM events (nexus events) are always applied without having an option to opt out. So we added a new option
enumspb.RESET_REAPPLY_EXCLUDE_TYPE_NEXUSto the list of excludable events. This change makes it possible to exclude nexus events from being reapplied.In a followup PR I will add option to completely skip
reapplyEvents()if all the events are excluded.How did you test it?
Added unit tests
Potential risks
N/A
Documentation
N/A
Is hotfix candidate?
No