Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Namespace example using TF tls provider to gen CA certs #118

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

jlacefie
Copy link
Collaborator

What was changed

This PR adds an example of using Hashi's tls resource to generate a CA and pass that into the Temporal Namespace resource.

The Namespace resource example was changed which triggered a change to the docs example as well.

Why?

Two approaches to change exist:

  • Add the tls resource example to the main Temporal Namespace example so doc generation updated the Namespace resource documentation to make this option visible to users (The path included in this PR)
  • Add a new TF CA Namespace resource example that does not trigger the doc generation tool to add this sample to docs

Checklist

  1. Closes

  2. How was this tested:
    Tested locally and created a Namespace using Hashi's tls resource

  • note : when I tested locally, i used comments to hide the simple, external CA, example from Terraform so only the tls CA based Namespace was created.
  1. Any docs updates needed?
    Yes - see the option chose in Why

@jlacefie jlacefie requested a review from a team as a code owner August 30, 2024 11:19
Copy link
Collaborator

@swgillespie swgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@swgillespie swgillespie merged commit d6bdaf5 into main Sep 4, 2024
4 of 5 checks passed
@swgillespie swgillespie deleted the certgen-example branch September 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants