-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add service account resource #126
add service account resource #126
Conversation
@jlacefie @swgillespie can you take a look at this PR too? Thank you! |
TY for the contribution!
|
@jlacefie I added the sample to this PR! I will also add it for other PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look great, thank you!
|
||
### Optional | ||
|
||
- `namespace_accesses` (Attributes List) The list of namespace accesses. (see [below for nested schema](#nestedatt--namespace_accesses)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blocking feedback, but just so you know - we've had some issues (#119, #116, #115) that have arisen from this tight coupling of users and namespace accesses as part of the same resource. I sketched out #122 but I haven't finished the full idea yet, but my thinking here was to add another resource that represents a namespace access that can be manipulated even if the user object is referenced as a data source. Something we might also want to do here, too.
What was changed
Adding Service Account CRUD support
Why?
Service Accounts are currently managed using tcld. Adding support with terraform plugin will make it easy to maintain it in code
Checklist
Closes [Feature Request] Add Service Account resource support #125
How was this tested:
make testacc
Any docs updates needed?
generated the docs