-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Key auth for namespaces #130
Open
kwadhwa-openai
wants to merge
5
commits into
temporalio:main
Choose a base branch
from
kwadhwa-openai:terraform_api_key_auth_for_namespaces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
API Key auth for namespaces #130
kwadhwa-openai
wants to merge
5
commits into
temporalio:main
from
kwadhwa-openai:terraform_api_key_auth_for_namespaces
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jlacefie @swgillespie another one :) |
jlacefie
reviewed
Sep 30, 2024
jlacefie
reviewed
Sep 30, 2024
jlacefie
reviewed
Sep 30, 2024
initial manual run of the test suite passes. running manually due to #131
|
kwadhwa-openai
force-pushed
the
terraform_api_key_auth_for_namespaces
branch
2 times, most recently
from
October 2, 2024 20:45
3b1efdd
to
bd0d1b4
Compare
kwadhwa-openai
force-pushed
the
terraform_api_key_auth_for_namespaces
branch
from
October 5, 2024 22:54
bd0d1b4
to
5078fbd
Compare
kwadhwa-openai
force-pushed
the
terraform_api_key_auth_for_namespaces
branch
from
October 5, 2024 23:10
5078fbd
to
2b2fd21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
This allows using API Keys to interact with namespaces
Checklist
Closes [Feature Request] API Key auth for namespaces #128 Closes [Feature Request] Allow specifying versions for cloud API via provider #129
How was this tested:
`make testacc
Any docs updates needed?
generated the docs