Skip to content

Commit

Permalink
add necessary classes to button as anchor tag (#1580)
Browse files Browse the repository at this point in the history
and only show indicator on select when not disabled
  • Loading branch information
rossedfort authored Aug 23, 2023
1 parent cfcb25d commit bcc9a35
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion src/lib/holocene/button.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,16 @@
<a
{href}
on:click|stopPropagation
class="button {variant} {className}"
class="button whitespace-nowrap {variant} {className}"
class:selected={active}
class:large
class:disabled
class:thin
class:unround
class:unroundRight
class:unroundLeft
class:noBorderRight
class:noBorderLeft
{target}
{id}
{...$$restProps}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/holocene/select/select.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
<MenuContainer class="w-full" {open}>
<label class:sr-only={labelHidden} for={id}>{label}</label>
<MenuButton
hasIndicator
hasIndicator={!disabled}
{disabled}
{unroundLeft}
{unroundRight}
Expand Down

1 comment on commit bcc9a35

@vercel
Copy link

@vercel vercel bot commented on bcc9a35 Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

holocene – ./

holocene.preview.thundergun.io
holocene-git-main.preview.thundergun.io

Please sign in to comment.