Fix workflow start disabled check (#2176)

* Fix boolean check * Add if statement to workflow-actions
temporalio · Jul 1, 2024 · c20600f · c20600f
1 parent 7a28811
commit c20600f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 16 deletions.
diff --git a/src/lib/components/workflow-actions.svelte b/src/lib/components/workflow-actions.svelte
@@ -141,21 +141,23 @@
         </MenuItem>
       </Tooltip>
     {/each}
-    <MenuDivider />
-    <MenuItem
-      on:click={() =>
-        goto(
-          routeForWorkflowStart({
-            namespace,
-            workflowId: workflow.id,
-            taskQueue: workflow.taskQueue,
-            workflowType: workflow.name,
-          }),
-        )}
-      data-testid="start-workflow-button"
-    >
-      {translate('workflows.start-workflow-like-this-one')}
-    </MenuItem>
+    {#if !workflowCreateDisabled($page)}
+      <MenuDivider />
+      <MenuItem
+        on:click={() =>
+          goto(
+            routeForWorkflowStart({
+              namespace,
+              workflowId: workflow.id,
+              taskQueue: workflow.taskQueue,
+              workflowType: workflow.name,
+            }),
+          )}
+        data-testid="start-workflow-button"
+      >
+        {translate('workflows.start-workflow-like-this-one')}
+      </MenuItem>
+    {/if}
   </SplitButton>
 {:else if !workflowCreateDisabled($page)}
   <SplitButton

diff --git a/src/lib/utilities/workflow-create-disabled.ts b/src/lib/utilities/workflow-create-disabled.ts
@@ -12,5 +12,7 @@ export const workflowCreateDisabled = (
   const namespaceWriteDisabled = get(coreUser).namespaceWriteDisabled(
     namespace ?? page.params.namespace,
   );
-  return page.data.settings.startWorkflowDisabled || namespaceWriteDisabled;
+  if (page.data.settings.startWorkflowDisabled) return true;
+
+  return namespaceWriteDisabled;
 };