Skip to content

Commit

Permalink
Audit a11y issues (#2135)
Browse files Browse the repository at this point in the history
* DT-2134 Fix a11y issues with accordion.svelte

* Remove on:keydown on CodeBlock

I could not find a single use of `CodeBlock` that had an on:keydown event. [Related ticket](https://temporalio.atlassian.net/browse/DT-2135).

* Update filter-or-copy-buttons.svelte

These both appear to be `noop` functions?
  • Loading branch information
stevekinney authored Jun 3, 2024
1 parent ae7e12a commit ce6e2b7
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
1 change: 1 addition & 0 deletions src/lib/holocene/accordion.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
<div
id="{id}-content"
aria-labelledby="{id}-trigger"
role="textbox"
class="mt-8 block w-full"
class:hidden={!open}
>
Expand Down
1 change: 0 additions & 1 deletion src/lib/holocene/code-block.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@

<div class="relative min-w-[80px] grow">
<div
on:keydown|stopPropagation
bind:this={editor}
class={className}
data-testid={$$props.testId}
Expand Down
6 changes: 1 addition & 5 deletions src/lib/holocene/filter-or-copy-buttons.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,7 @@
</script>

{#if show}
<div
class={merge('copy-or-filter', className)}
on:click|preventDefault|stopPropagation={noop}
on:keyup|preventDefault|stopPropagation={noop}
>
<div class={merge('copy-or-filter', className)}>
{#if filterable}
<button
on:click|preventDefault|stopPropagation={onFilter}
Expand Down

0 comments on commit ce6e2b7

Please sign in to comment.