Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text styles audit #2236

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Text styles audit #2236

merged 11 commits into from
Jul 31, 2024

Conversation

laurakwhit
Copy link
Contributor

@laurakwhit laurakwhit commented Jul 24, 2024

Description & motivation 💭

  • Adds textStyles plugin with
    • default font sizing and weight for heading elements
    • body text style classes
  • Audits existing heading elements for font sizing and weight
  • Sets sans font family (instead of primary vs. secondary)
  • Removes set icon size in Link component

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-2000

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested review from rossedfort and a team as code owners July 24, 2024 20:46
Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 5:04pm

src/app.css Outdated Show resolved Hide resolved
src/app.css Show resolved Hide resolved
@laurakwhit laurakwhit merged commit d39dd5e into main Jul 31, 2024
14 checks passed
@laurakwhit laurakwhit deleted the DT-2000-responsive-font-sizing branch July 31, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants