Dark slider #2240
Merged
Dark slider #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KATIETOLER
approved these changes
Jul 29, 2024
laurakwhit
reviewed
Jul 30, 2024
| @@ -76,6 +76,9 @@ const temporal = plugin( | |||
| backgroundColor: css('--color-interactive-ghost-active'), | |||
| }, | |||
| }, | |||
| '.surface-information': { | |||
| backgroundColor: css('--color-surface-information'), | |||
There was a problem hiding this comment.
@GraceGardner just wanted to follow-up here before I make any changes! Was there a specific reason surface-information was added here? Looks like we're just using backgroundColor and that already exists ⬇️
Line 131 in 5f41480
There was a problem hiding this comment.
I've gone ahead and removed it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Adjust Range input styling to match new designs.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-2061
Docs
Any docs updates needed?