Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove expand when slot is empty #2242

Merged
merged 11 commits into from
Aug 19, 2024
Merged

remove expand when slot is empty #2242

merged 11 commits into from
Aug 19, 2024

Conversation

GraceGardner
Copy link
Contributor

@GraceGardner GraceGardner commented Jul 30, 2024

Description & motivation 💭

Removes hover states, chevron and ability to expand accordion when slot is empty.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

Storybook

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Please checkout the accordion component in storybook

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-2312

Docs

Any docs updates needed?

@GraceGardner GraceGardner requested review from rossedfort and a team as code owners July 30, 2024 18:38
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 7:33pm

server/go.mod Outdated Show resolved Hide resolved
Co-authored-by: Laura Whitaker <[email protected]>
@GraceGardner GraceGardner merged commit 38fa5e3 into main Aug 19, 2024
14 checks passed
@GraceGardner GraceGardner deleted the disable-empty-accordian branch August 19, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants