Add ability to query schedules #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurakwhit
commented
Aug 19, 2024
src/lib/pages/schedules.svelte
Outdated
| {#if !createDisabled && visibleItems.length} | ||
| {#if showActions} | ||
| <div class="w-96"> | ||
| <Input |
There was a problem hiding this comment.
Wondering if we want to keep this client side search for now or just remove it? Filtering by Schedule Id should be available with the next release.
There was a problem hiding this comment.
I think we remove it and add support for the scheduleId query. Can add a 1.25 server version guard on that option
laurakwhit
requested review from
stevekinney,
Alex-Tideman,
rossedfort and
a team
as code owners
laurakwhit
force-pushed
the
DT-2017-query-schedules
branch
from
5bda38f
to
54e11c1
Compare
laurakwhit
force-pushed
the
DT-2017-query-schedules
branch
from
54e11c1
to
75c8805
Compare
laurakwhit
force-pushed
the
DT-2017-query-schedules
branch
from
75c8805
to
9c0ad75
Compare
Alex-Tideman
approved these changes
Aug 20, 2024
laurakwhit
changed the base branch from
main
to
search-attributes-for-schedules
laurakwhit
added a commit
that referenced
this pull request
Sep 10, 2024
* Schedule search attributes (#2241) * Add search attributes to create schedule UI * Add search attributes to edit schedule UI * Fix search attribute inputs based on search attribute type * Add search attributes to schedule view UI * Use custom datetime input with UTC * Small UI and copy fixes * Fix attribute value to always update on attribute change * Fix label spacing and update custom search attribute table to be list instead * Update schedule advanced settings to be list * Fix search attribute view/create/update * Fix type * Add expandable prop to search attribute Accordion --------- Co-authored-by: Alex Tideman <[email protected]> * Add ability to query schedules (#2272) * Refactor FilterSearch to component for reuse on Schedules page * Rename filter search to search attribute filter * Make schedules table headers configurable * Add back schedule name search input * Fix responsiveness * Only add starts with option to TextFilter if attribute is a Keyword * Fix empty state * update testId * Add onError callback * Remove schedule name search input * Add search attribute type map * Add ScheduleId filter option and rename table header * Use Input required prop on schedule form * Add isCloud check for ScheduleId * Add unspecified search attribute type --------- Co-authored-by: Alex Tideman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Adds ability to query schedules for custom search attributes.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
addedupdatedSteps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-2017Docs
Any docs updates needed?