DT-2499 - wf reset ux improvement #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't highlight workflow task failure error in event history table if ResetWorkflow error
rossedfort
requested review from
stevekinney,
Alex-Tideman and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| $: { | ||
| cause = getErrorCause(error); | ||
| } | ||
| </script> | ||
|
|
||
| {#if cause} | ||
| {#if cause && cause !== 'ResetWorkflow'} |
There was a problem hiding this comment.
I'm sure there will be more of these cases but not gonna overthink trying to abstract that way yet. This is fine.
Alex-Tideman
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Apparently a
WorkflowTaskFailedevent in the even history of a workflow execution that is the result of a reset is expected. This PR adjusts the styling/content of the workflow details page for this case so that it doesn't look like things went wrong.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?