This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: None (mostly spontaneous)
This is a relatively "minor" PR (in changes), but it's a rather big refactoring. Essentially, I've ran clang-tidy over the code base and fixed what I thought would be good to fix. Notably, I think this could help for #56. C++20 is probably more restrictive towards the syntax and stuff like this.
Alongside this, I've made another minor change, which is to let the startup splash screen show until the main project window is shown. In my opinion, this makes more sense, so that if the splash screen closes unexpectedly, you immediately know there's a problem, for example.
Finally, I've updated the BUILDING.md file to add a note, which says that building wxWidgets as a static library will cause Saucedacity to fail to launch.
*Indicates required.