support python 3 #40
support python 3 #40
Conversation
qcloud_cos/cos_auth.py
Outdated
| except ImportError: | ||
| from urllib.parse import quote # Python 3+ | ||
|
|
||
| from .helper import smart_str, smart_bytes |
There was a problem hiding this comment.
I am not sure whether this importation is worked on Python3. Python3 supports absolute import only. It would be better to update to from qcloud_cos.helper import smart_str, smart_bytes.
There was a problem hiding this comment.
btw, I prefer to use
from __future__ import absolute_import
from qcloud_cos.helper import smart_str, smart_bytes
qcloud_cos/cos_op.py
Outdated
| logger.debug("sending request, method: %s, bucket: %s, cos_path: %s" % (method, bucket, cos_path)) | ||
| print('url' * 10) |
There was a problem hiding this comment.
do not like print in library. using logging would be better. 👍
| @@ -105,6 +113,7 @@ def send_request(self, method, bucket, cos_path, **kwargs): | |||
| http_resp = self._http_session.get(url, verify=False, **kwargs) | |||
|
|
|||
| status_code = http_resp.status_code | |||
| print(http_resp, http_resp.headers) | |||
qcloud_cos/cos_params_check.py
Outdated
| :param param_name: param_name 参数名 | ||
| :param param_value: param_value 参数值 | ||
| :return: | ||
| """ | ||
| if param_value is None: | ||
| self._err_tips = param_name + ' is None!' | ||
| return False | ||
| if not isinstance(param_value, unicode): | ||
| if six.PY3: |
There was a problem hiding this comment.
six has a type alias called string_types, could we use it here?
| @@ -555,41 +557,26 @@ def check_params_valid(self): | |||
| if not super(UpdateFileRequest, self).check_params_valid(): | |||
| return False | |||
|
|
|||
| check_unicode_params = { | |||
setup.py
Outdated
| @@ -4,9 +4,6 @@ | |||
| import sys | |||
| from setuptools import setup, find_packages | |||
|
|
|||
| if sys.version_info[0] != 2 or sys.version_info[1] < 6: | |||
| sys.exit('Sorry, only python 2.6 or 2.7 is supported') | |||
|
|
|||
| setup(name='qcloud_cos_v4', | |||
| version='0.0.20', | |||
There was a problem hiding this comment.
I would like to update version to 1.0.0 if we could merge this. : )
local_file_2.txt
Outdated
| @@ -0,0 +1 @@ | |||
| hello world2 | |||
There was a problem hiding this comment.
i can't find where it is used. is it a tmp file?
|
Auth 添加 appid, secret_id, secret_key 参数，以便可以单独使用 |
|
请添加 six 依赖 |
|
tox.ini 中也要添加 six 依赖 |
|
没有找到这个文件 |
|
什么时候可以 merge？ |
|
@liuchang0812 希望尽快 Merge |
|
😲 还没 review 。。。 |
No description provided.