-
Notifications
You must be signed in to change notification settings - Fork 656
Fixing notebook and adding jupyter #254
base: master
Are you sure you want to change the base?
Fixing notebook and adding jupyter #254
Conversation
causing errors when loading a text file
… to be a tensor. It allow the notebook Activation Grid to work
…tionGrid notebook
…pletes the tutorial notebook.
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
The Jupyter notebooks are placed in a folder "jupyter_versions" in each package folder. Currently it is only the case for building-blocks (notebooks/building-blocks). I forgot to list the other features of my PR :
|
…tain every outputs
Hi @Shulk97 ! Wow, that's quite a PR; so sorry for ignoring it for so long! I'd still be happy to merge all of these, but since I'm about a year late, I'd need you to rebase on master first. Since your PR comes from a fork, I don't think I can do so for you. Once you've rebased I hope tests should pass again, and then I'd be happy to merge. Thank you for your contributions! Once they're merged, we should think about how to signpost them to future users; e.g. I think we could add some of your sample notebooks to the public README if you're up for it? |
The actual text in this docstring line was taken from the docstring of read, since that appears to be the main place where the cache kwarg gets propagated down to in order to actually affect behavior.
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <[email protected]>
This should remove all current dependency vulnerability issues. When rebuilding this test folder, it can be regenerated, so it is safe to remove at the moment.
Added compatibility with Colab: switching to Tensorflow v.1
- Changed "facotrization" to "factorization".
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Hello @ludwigschubert ! Thank you for your reply I would be happy to contribute to Lucid. The tests are passing again thanks to the rebase, however it seems that the consent of some authors of the rebased commits is missing. Could you see which consents are missing ? If my pull request is accepted I could then propose an update of the README taking account of my contributions. |
Hi @Shulk97 ! I've run into that issue before; I just wish the bot would point us to the offending commits! (It's likely just a stray email address.) I'll take a look on Monday (it's EOD in my time zone already) and take it from here; thanks for updating! PS: Agree that we should add them to the reader; if you already want to prepare: see if you want to make a thumbnail like we have done for the other notebooks? (But no pressure!) |
…nerate spritemaps
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Fixed various problems concerning notebooks from packages Feature Visualisation and Building Block such as code remaining in Python 2 or bugs occurring in the save and load functions of the package misc.io.
Adding of Jupyter versions of several notebooks that are meant to be used on the user's machine for his own model. It includes widgets in order to be easy to use.