Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Update CMakeLists.txt for shared library build #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stephenneuendorffer
Copy link

There are several circular dependencies between libraries. These
are explicitly marked as STATIC. Note that add_llvm_library is redundant
with add_dependencies, so we don't have to have libraries in both places.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

There are several circular dependencies between libraries.  These
are explicitly marked as STATIC.  Note that add_llvm_library is redundant
with add_dependencies, so we don't have to have libraries in both places.
@jpienaar
Copy link
Member

jpienaar commented Oct 3, 2019

Hey Stephen,

Could you verify if you've signed the CLA?

Thanks,

Jacques

@joker-eph joker-eph force-pushed the master branch 3 times, most recently from 48dcae0 to 3722f03 Compare December 26, 2019 04:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants