Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for triangular_solve BEF executable unit test failure on ROCm. #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rsanthanam-amd
Copy link
Contributor

@hanbinyoon
Copy link
Member

Nit: Could we please initialize a_num_elements to n * n? Something like:

int32_t a_num_elements = n * n;
if ((platform == wrapper::Platform::CUDA && side_mode == CUBLAS_SIDE_LEFT) ||
(platform == wrapper::Platform::ROCm && side_mode == rocblas_side_left))
a_num_elements = m * m;

Otherwise, looks good! :)

@rsanthanam-amd rsanthanam-amd force-pushed the rocm_triangular_solve_test_fix branch from 97c4c10 to aa34cc0 Compare May 10, 2022 18:03
@rsanthanam-amd
Copy link
Contributor Author

Nit: Could we please initialize a_num_elements to n * n? Something like:

int32_t a_num_elements = n * n; if ((platform == wrapper::Platform::CUDA && side_mode == CUBLAS_SIDE_LEFT) || (platform == wrapper::Platform::ROCm && side_mode == rocblas_side_left)) a_num_elements = m * m;

Otherwise, looks good! :)

Done.

@jing-dong jing-dong requested review from chsigg and removed request for jing-dong May 10, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants