Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ API test with synthetic data #284

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

C++ API test with synthetic data #284

wants to merge 1 commit into from

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Jan 17, 2022

Test program to run TF-TRT conversion with the C++API with synthetic data.

This is based on #271

Todo

  • rename / clean up files
  • script to launch test

@DEKHTIARJonathan
Copy link
Collaborator

@meena-at-work: for review

meena-at-work
meena-at-work reviewed Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@meena-at-work meena-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks fine to me as is -- considering that it is intended to be a standalone example of using synthetic data (and not a benchmark). If you can address the one small nit, I think it's good to go.

tftrt/examples/cpp/image-classification/mnist.h Outdated
// Converts an MNIST Image to a tensorflow Tensor.
tensorflow::Tensor MNISTImageToTensor(int offset, int batch_size);

std::vector<mnist::MNISTImage> images;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit here -- can you name the member variables with a m_images or images_ so we know that they're member variables?

@meena-at-work meena-at-work self-requested a review June 27, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meena-at-work meena-at-work Awaiting requested review from meena-at-work

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfeher @DEKHTIARJonathan @meena-at-work