Fix issue with transposing shape in CMSIS-NN batch matmul #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG=tensorflow#2740 Signed-off-by: Ryan O'Shea <[email protected]>
|
Is there any test to catch the issue? If no existing, could we add one, that fails without the fix? |
|
Some more context.. This was actually caught by one of the unit tests. It was an out of bound read but with GCC it was actually passing by "luck". However not when using armclang. So it was actually seen during testing of this PR and without the fix this new tests will fail: #2750 |
|
Ah I see. Thanks for the context. |
suleshahid
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=#2740