Skip to content

Commit

Permalink
Output to bazel-bin instead of bazel-genfiles.
Browse files Browse the repository at this point in the history
In the long term, all uses of bazel-genfiles will be replaced with bazel-bin. Starlark rules should only set `output_to_genfiles = True` when required for compatibility with other rules or tools that make assumptions about the location of output files.

Note that Bazel already defaults to `--incompatible_merge_genfiles_directory`, which makes the distinction moot anyway.

PiperOrigin-RevId: 612915158
  • Loading branch information
tjgq authored and tflite-support-robot committed Mar 5, 2024
1 parent 483c45d commit bfbf974
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions third_party/flatbuffers/build_defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,6 @@ _gen_flatbuffer_srcs = rule(
cfg = "exec",
),
},
output_to_genfiles = True,
)

def flatbuffer_py_strip_prefix_srcs(name, srcs = [], strip_prefix = ""):
Expand Down Expand Up @@ -407,7 +406,6 @@ _concat_flatbuffer_py_srcs = rule(
attrs = {
"deps": attr.label_list(mandatory = True),
},
output_to_genfiles = True,
outputs = {"out": "%{name}.py"},
)

Expand Down

0 comments on commit bfbf974

Please sign in to comment.