Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference mode and TF compatibility #16

Merged
merged 10 commits into from
Sep 24, 2018
Merged

Conversation

pskrunner14
Copy link
Contributor

@pskrunner14 pskrunner14 commented Sep 21, 2018

  • Moved Inference code to a function.
  • Added optional arguments including running script in inference mode [usage python main.py --help].
  • Added tqdm progress bar for info while training.
  • Made the code compatible with TF v1.10.0 and TL v1.10.1.
  • Changed tf.contrib.rnn.BasicLSTMCell to tf.nn.rnn_cell.LSTMCell since the former is deprecated.
  • Moved session config to global scope.
  • Refactored code into relevant functions and reordered them so that the higher-level ones appear earlier in the code.
  • Renamed script to main.py for ease of use.
  • Updated README to add training and inference usage commands.
  • Added requirements.txt file.
  • Changed n.npz to model.npz since it is more standard.

Note: Fixes #12 and #15

@pskrunner14
Copy link
Contributor Author

@zsdonghao kindly resolve the file rename conflict and review PR. Thanks.

Copy link
Member

@zsdonghao zsdonghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks a lot for code reorg.

@zsdonghao
Copy link
Member

Could you resolve the conflicts and then the PR is ready to merge to me.

@pskrunner14
Copy link
Contributor Author

@zsdonghao ready to merge.

@zsdonghao zsdonghao merged commit 108f378 into tensorlayer:master Sep 24, 2018
zsdonghao pushed a commit that referenced this pull request Sep 28, 2018
* fixes tl global vars init deprecated issue #13 and impove code readability

* inference mode and refactor

* requirements and minor changes

* moved inference to train

* revert back file name to resolve merge conflict

* rename script

* some cleanup

* move sess init
luomai added a commit that referenced this pull request Sep 28, 2018
zsdonghao pushed a commit that referenced this pull request Sep 28, 2018
* fixes tl global vars init deprecated issue #13 and impove code readability

* inference mode and refactor

* requirements and minor changes

* moved inference to train

* revert back file name to resolve merge conflict

* rename script

* some cleanup

* move sess init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants