Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try converting aten.cat to ttnn.concat #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Try converting aten.cat to ttnn.concat #188

wants to merge 1 commit into from

Conversation

jdh8
Copy link
Collaborator

@jdh8 jdh8 commented Sep 12, 2024

Ticket

Subproblem of tenstorrent/tt-metal#12853

Problem description

Data movement pass does not take effect. A difference is that aten.cat takes a list of tensors instead of a fixed number of tensors.

E       TypeError: __call__(): incompatible function arguments. The following argument types are supported:
E           1. (self: ttnn._ttnn.operations.data_movement.concat_t, tensors: List[ttnn._ttnn.deprecated.tensor.Tensor], dim: int = 0, *, output_tensor: Optional[ttnn._ttnn.deprecated.tensor.Tensor] = None, memory_config: Optional[ttnn._ttnn.deprecated.tensor.MemoryConfig] = None, queue_id: int = 0) -> ttnn._ttnn.deprecated.tensor.Tensor
E
E       Invoked with: <ttnn._ttnn.operations.data_movement.concat_t object at 0x7fd912468d30>, [tensor([[0.5938, 0.2500],
E               [0.4453, 0.0078],
E               [0.7539, 0.1328],
E               [0.6406, 0.1367]], dtype=torch.bfloat16), tensor([[0.4219, 0.3867],
E               [0.0977, 0.8945],
E               [0.2344, 0.1953],
E               [0.9023, 0.4375]], dtype=torch.bfloat16)], 1

../venv/lib/python3.8/site-packages/ttnn/decorators.py:326: TypeError

What's changed

  • Restore conversion aten.catttnn.concat
  • Reenable test for aten.catttnn.concat

Data movement pass does not take effect.  A difference is that `aten.cat` takes
a list of tensors instead of a fixed number of tensors.

```
E       TypeError: __call__(): incompatible function arguments. The following argument types are supported:
E           1. (self: ttnn._ttnn.operations.data_movement.concat_t, tensors: List[ttnn._ttnn.deprecated.tensor.Tensor], dim: int = 0, *, output_tensor: Optional[ttnn._ttnn.deprecated.tensor.Tensor] = None, memory_config: Optional[ttnn._ttnn.deprecated.tensor.MemoryConfig] = None, queue_id: int = 0) -> ttnn._ttnn.deprecated.tensor.Tensor
E
E       Invoked with: <ttnn._ttnn.operations.data_movement.concat_t object at 0x7fd912468d30>, [tensor([[0.5938, 0.2500],
E               [0.4453, 0.0078],
E               [0.7539, 0.1328],
E               [0.6406, 0.1367]], dtype=torch.bfloat16), tensor([[0.4219, 0.3867],
E               [0.0977, 0.8945],
E               [0.2344, 0.1953],
E               [0.9023, 0.4375]], dtype=torch.bfloat16)], 1

../venv/lib/python3.8/site-packages/ttnn/decorators.py:326: TypeError
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants