-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert aten.repeat
to ttnn.repeat
#189
Conversation
@jdh8 can you please review this list? We have this for every op. Wdyt? |
8431366
to
2345e96
Compare
aten.repeat
to ttnn.repeat
aten.repeat
to ttnn.repeat
((6, 2), (361, 1)), | ||
((6, 2), (4, 1)), | ||
((6, 2), (400, 1)), | ||
((6, 2), (9, 1)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just refined the conversion so that our use cases should pass.
reason="Current repeat implementation requires aligned last dim when repeating on last dim" | ||
), | ||
), | ||
((5, 16), (2, 3)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These cases are not in the list of input variations. I leave them for future improvement.
Error message: ``` E RuntimeError: TT_FATAL @ /home/runner/work/tt-metal/tt-metal/ttnn/cpp/ttnn/operations/data_movement/repeat/repeat.cpp:37: (input_tensor.get_legacy_shape()[dim] * input_tensor.element_size()) % input_tensor.buffer()->alignment() == 0 E info: E Current repeat implementation requires aligned last dim when repeating on last dim ```
c9e292a
to
f4372c9
Compare
I'm merging this because it may help #146 |
Ticket
Subproblem of tenstorrent/tt-metal#12853
Problem description
This happens when repeating non-aligned innermost dimension. Luckily, this does not happen in our input variations.
What's changed
aten.repeat
→ttnn.repeat
aten.repeat
→ttnn.repeat