Fix: Calling update reshape attribute function for non reshape ops #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||||||||||||||
|
||||||||||||||
ashokkumarkannan1
changed the title
ashokkumarkannan1
force-pushed
the
akannan/fix_update_reshape_attr
branch
from
dbd7efc to
b02266e
Compare
ashokkumarkannan1
requested review from
nvukobratTT,
pilkicTT and
dgolubovicTT
as code owners
|
||||||||||||||
|
||||||||||||||
nvukobratTT
approved these changes
Jan 21, 2025
|
@ashokkumarkannan1 how does this affect this PR #833? |
@dgolubovicTT This update_reshape_attr function is the first issue we faced even for XGLM model. After this fix only, we got this issue with `ttir.squeeze. So Merging this PR won't be a blocker for this PR |
|
@dgolubovicTT I will proceed with merging this PR. If you have any comments around this, Please let me know. |
pdeviTT
pushed a commit
that referenced
this pull request
Jan 21, 2025
…1038) Fix: #816 This PR fixes the `update_reshape_attr called for a non-reshape operation`. This is from commute_utils in erase inverse ops logic, where this `update_reshape_attr` function called for squeeze, unsqueeze and transpose ops. So added a condition to only call this for reshape ops. Tested for Bart model and verified. Log Before Fix - [test_bart_without_fix.log](https://github.com/user-attachments/files/18486202/test_bart_without_fix.log) Log After Fix - [test_bart_with_fixt.log](https://github.com/user-attachments/files/18486199/test_bart_with_fixt.log)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #816
This PR fixes the
update_reshape_attr called for a non-reshape operation. This is from commute_utils in erase inverse ops logic, where thisupdate_reshape_attrfunction called for squeeze, unsqueeze and transpose ops. So added a condition to only call this for reshape ops.Logs
Tested for Bart model and verified.
Log Before Fix - test_bart_without_fix.log
Log After Fix - test_bart_with_fixt.log