#12840: Add more handling more multiple attempts by restricting the space of github_job_ids we're looking to only the ones in the workflow run attempt in question
#12858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g all of them, so that the system doesn't get confused when searching for artifacts that were generated in a previous attempt but weren't carried over
… downloaded logs to a test report, only match the ones for the requested job, so we don't handle more than we need to and run into issues such as what we currently have where multiple attempts of a workflow run will cause multiple github_job_ids to have the same uuid, meaning we can't match later because we lose data
tt-rkim
force-pushed
the
rkim/12840-multiple-attempts
branch
from
3564a6d
to
1a361c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#12840
Problem description
We weren't handling the case properly where artifacts would carry over from successful jobs from previous workflow run attempts. However, at the same time, based on anecdotal sniffing of the GitHub API, it seems that jobs in subsequent workflow run attempts will actually have different IDs.
This means we got into a situation where in our
uuid -> github_job_idmapping, we could have multiplegithub_job_ids for the sameuuid. This caused a keyerror in certain cases.What's changed
github_job_idand construct a mapping betweengithub_job_id -> uuidrather than other way around. This causes clashes for a givenuuid.Checklist