#12758: Add queue_id and optional output tensors to div and trunc op #12861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KalaivaniMCW
approved these changes
Sep 19, 2024
mouliraj-mcw
requested review from
eyonland,
patrickroberts,
yan-zaretskiy,
cfjchu,
xanderchin,
TT-BrianLiu,
ayerofieiev-tt,
dmakoviichuk-tt,
razorback3 and
dongjin-na
as code owners
mouliraj-mcw
force-pushed
the
mouliraj/div_opt
branch
from
8165bdf
to
27db75d
Compare
eyonland
approved these changes
Sep 20, 2024
mouliraj-mcw
force-pushed
the
mouliraj/div_opt
branch
from
27db75d
to
503fb15
Compare
mouliraj-mcw
force-pushed
the
mouliraj/div_opt
branch
from
503fb15
to
d3d5e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue #12758 , #12763
What's changed
Perf before vs after:
op,count,python min dispatch time (ms),python mean dispatch time(ms),python mean dispatch + sync time (ms)
ttnn.div, 800, 0.105, 0.132, 0.756, 0.038 (Before)
ttnn.div, 800, 0.112, 0.132, 0.756, 0.037 - (After)
Checklist