#12901: Remove extraneous value: int parameter from ttnn.bitwise_not
#12902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdh8
requested review from
patrickroberts,
yan-zaretskiy and
eyonland
as code owners
3 tasks
ayerofieiev-tt
approved these changes
Sep 19, 2024
eyonland
reviewed
Sep 20, 2024
jdh8
force-pushed
the
fix/bitwise_not
branch
from
a58b1d9
to
52045f1
Compare
|
@jdh8 this also requires bindings and tests update. |
jdh8
requested review from
rtawfik01,
rdjogoTT and
ttmtrajkovic
as code owners
jdh8
commented
Sep 30, 2024
| @@ -898,7 +897,7 @@ def eltwise_bitwise_not( | |||
| **kwargs, | |||
| ): | |||
| t0 = setup_tt_tensor(x, device, layout[0], input_mem_config[0], dtype[0]) | |||
| t1 = ttnn.bitwise_not(t0, value, memory_config=output_mem_config, queue_id=0) | |||
| t1 = ttnn.bitwise_not(t0, memory_config=output_mem_config, queue_id=0) | |||
There was a problem hiding this comment.
Besides this, is there any test that need to update? BTW, how do I run tests locally?
jdh8
commented
Sep 30, 2024
| @@ -326,6 +322,9 @@ std::pair<string, string> get_op_init_and_func_default(UnaryOpType op_type, std: | |||
| case UnaryOpType::NEG: | |||
| op_init_and_name = {"negative_tile_init();", fmt::format("negative_tile({});", idst)}; | |||
| break; | |||
| case UnaryOpType::BITWISE_NOT: | |||
| op_init_and_name = {"bitwise_not_tile_init();", fmt::format("bitwise_not_tile({});", idst)}; | |||
There was a problem hiding this comment.
C/C++ code as string interests me a lot. Does it mean that we collate the C/C++ code somewhere and invokes a compiler in turn?
Bitwise NOT simply flips all bits. It uses no additional value. This issue blocks tenstorrent/pytorch2.0_ttnn#236
|
This PR was covered by #13579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
value: intparameter fromttnn.bitwise_not#12901aten.bitwise_nottottnn.bitwise_notpytorch2.0_ttnn#236Problem description
Bitwise NOT simply flips all bits. It uses no additional value.
What's changed
Remove extraneous
value: intparameter fromttnn.bitwise_notChecklist