#12891: Copy generated artifacts out of docker container so that we can upload test results #12959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifacts generated after the test command into it so that we have access to it on the host
…/ to start off so that we don't fail on cp generated/*
This reverts commit 027d7ca.
TT-billteng
reviewed
Sep 21, 2024
| id: prepare-for-artifacts | ||
| shell: bash | ||
| run: | | ||
| mkdir -p ${{ github.workspace }}/generated |
There was a problem hiding this comment.
told @dimitri-tenstorrent that we should get the docker mounting permissions working so that this shouldn't be necessary
|
passing post commit https://github.com/tenstorrent/tt-metal/actions/runs/10997551580 but gonna wait on @dimitri-tenstorrent + @ttmchiou changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#12891
Problem description
We were not uploading test reports anymore because they were hidden in the container after we moved to Dockerized test pipelines.
What's changed
We copy them back out with some tricks to fix the permissions.
Checklist