-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#14862: fp32 support in unary #14899
Conversation
9c1110f
to
e11ae6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure that we don't loose any performance. But looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please add a few more random tests for a couple of ops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for enabling FP32 support for unary ops. Looks good overall.
Please create separate test for each unary op to make sure that this fix works.
621e6a3
to
41b90fc
Compare
41b90fc
to
3eab4ab
Compare
Ticket
Link to Github Issue #14862
Problem description
Provide context for the problem.
What's changed
Enabled
preserve_fp32_precision
flag for float32 inputChecklist
https://github.com/tenstorrent/tt-metal/actions/runs/11797734586