Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14862: fp32 support in unary #14899

Merged
merged 1 commit into from
Nov 12, 2024
Merged

#14862: fp32 support in unary #14899

merged 1 commit into from
Nov 12, 2024

Conversation

KalaivaniMCW
Copy link
Contributor

@KalaivaniMCW KalaivaniMCW commented Nov 8, 2024

Ticket

Link to Github Issue #14862

Problem description

Provide context for the problem.

What's changed

Enabled preserve_fp32_precision flag for float32 input

Checklist

@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/unary_fp32 branch 2 times, most recently from 9c1110f to e11ae6b Compare November 8, 2024 17:13
@KalaivaniMCW KalaivaniMCW marked this pull request as ready for review November 8, 2024 17:15
Copy link
Contributor

@eyonland eyonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure that we don't loose any performance. But looks good.

Copy link
Contributor

@dmakoviichuk-tt dmakoviichuk-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Please add a few more random tests for a couple of ops.

Copy link
Contributor

@rfurko-tt rfurko-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enabling FP32 support for unary ops. Looks good overall.
Please create separate test for each unary op to make sure that this fix works.

@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/unary_fp32 branch 6 times, most recently from 621e6a3 to 41b90fc Compare November 12, 2024 12:55
@KalaivaniMCW KalaivaniMCW merged commit 0039938 into main Nov 12, 2024
9 checks passed
@KalaivaniMCW KalaivaniMCW deleted the kalaivani/unary_fp32 branch November 12, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants