#5424: Clean up Sfpu Sign kernel api #16809
Open
+27
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atatuzunerTT
requested review from
rtawfik01,
rdjogoTT,
ttmtrajkovic,
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
tt-aho
approved these changes
Jan 16, 2025
rdjogoTT
approved these changes
Jan 16, 2025
rtawfik01
approved these changes
Jan 17, 2025
| @@ -18,8 +18,10 @@ inline void llk_math_eltwise_unary_sfpu_sign_init() { | |||
| } | |||
|
|
|||
| template <bool APPROXIMATE> | |||
There was a problem hiding this comment.
Can you add a comment here explaining the exponent_size_8 flag and why its defaulted to 1?
| @@ -18,8 +18,10 @@ inline void llk_math_eltwise_unary_sfpu_sign_init() { | |||
| } | |||
|
|
|||
| template <bool APPROXIMATE> | |||
There was a problem hiding this comment.
Same thing here, a small comment about exponent_size_8
| @@ -18,8 +18,10 @@ inline void llk_math_eltwise_unary_sfpu_sign_init() { | |||
| } | |||
|
|
|||
| template <bool APPROXIMATE> | |||
amahmudTT
reviewed
Jan 17, 2025
| @@ -61,6 +62,8 @@ bfloat16 sfpu_function(const string& op_name, const bfloat16& input) { | |||
| return bfloat16(logf(input.to_float())); | |||
| } else if (op_name == "tanh") { | |||
| return bfloat16(std::tanh(input.to_float())); | |||
| } else if (op_name == "sign") { | |||
| return bfloat16((0.0f < input.to_float()) ? 1.0f : ((input.to_float() < 0.0f) ? -1.0f : 0.0f)); | |||
There was a problem hiding this comment.
Have you checked what it does when you give it -0.0f ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Ckernel sfpu functions are implemented both in third party llk layer and metal llk api layer. The goal is to remove any duplicates and have llk api layer to call the implementation in third party. This PR is concerned with the clean up (i.e. removal of duplicates) of the calculate_sign API located at:
What's changed
Removed duplicate implementation for all architectures (i.e. bh, wh and gs). This API now calls the corresponding third party function calculate_sign that implements the functionality. Added test case in the sfpu_compute test suite for llks.
Checklist