Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Power of 2 Limit from Packet Queue #16811

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Removing Power of 2 Limit from Packet Queue #16811

wants to merge 4 commits into from
+264 −155

Conversation

nhuang-tt
Copy link
Member

@nhuang-tt nhuang-tt commented Jan 16, 2025 •
edited
Loading

Ticket

#14427

Problem description

Remove power of 2 limit from packet queue

What's changed

  • Registers are being used as credit words now instead of pointer offset
  • Added pointer calculations for non power of 2 queue sizes
  • Power of 2 AND mask can be enabled using define POW2_CB
  • Static asserts to only check for power of 2 if POW2_CB is defined

Checklist

@nhuang-tt nhuang-tt changed the base branch from nhuang/packet-queue-ci-check-2 to nhuang/packet-queue-ci-check-1 January 16, 2025 16:47
@nhuang-tt nhuang-tt marked this pull request as ready for review January 16, 2025 16:51
This was linked to issues Jan 16, 2025
remove power of 2 restriction for mux/demux, increase dispatch buffer size #14427
Closed
Packet queue performance can be improved #15474
Closed
@nhuang-tt nhuang-tt force-pushed the nhuang/packet-queue-ci-check-1 branch 2 times, most recently from ecf5355 to 74ef10d Compare January 16, 2025 22:57
@nhuang-tt nhuang-tt force-pushed the nhuang/packet-queue-ci-check-3 branch 3 times, most recently from c9ed89d to 723c21e Compare January 17, 2025 00:59
Base automatically changed from nhuang/packet-queue-ci-check-1 to main January 17, 2025 17:03
@nhuang-tt
#14427: use registers as credits
1afaba5
@nhuang-tt
#14427: logical and physical pointer offsets
85ea401
@nhuang-tt
#14427: non power of 2 pointer calculations
b6efe42
@nhuang-tt
#14427: dynamic eth tunneler queue sizing
bcb1a05 
eth tunneler queue size will be determined based on the eth
L1 size and number of channels needed

static queue size can be re-enabled by providing
TT_METAL_DISPATCH_STATIC_QUEUE_SIZING
@nhuang-tt nhuang-tt force-pushed the nhuang/packet-queue-ci-check-3 branch from 723c21e to bcb1a05 Compare January 17, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubcheema ubcheema ubcheema approved these changes

@aliuTT aliuTT Awaiting requested review from aliuTT aliuTT is a code owner

@abhullar-tt abhullar-tt Awaiting requested review from abhullar-tt abhullar-tt is a code owner

@pgkeller pgkeller Awaiting requested review from pgkeller pgkeller is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@tt-dma tt-dma Awaiting requested review from tt-dma tt-dma is a code owner

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nhuang-tt @ubcheema