Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Datagram Sockets to Fabric #16830

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Datagram Sockets to Fabric #16830

wants to merge 2 commits into from
+2,969 −185

Conversation

aagarwalTT
Copy link
Contributor

@aagarwalTT aagarwalTT commented Jan 16, 2025 •
edited
Loading

Ticket

Link to Github Issue

Problem description

Fabric implementation currently supports low level writes and atomic inc APIs.

What's changed

Adds Datagram Sockets feature to fabric. Introduces a gatekeeper kernel for context management with corresponding updates to existing tests.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@aagarwalTT aagarwalTT force-pushed the aagarwal/datagram-sockets branch from 947b78e to a46296a Compare January 17, 2025 18:26
aliuTT
aliuTT approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@aliuTT aliuTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add relevant tests to .github/workflows/t3000-unit-tests-impl.yaml and .github/workflows/tg-unit-tests-impl.yaml?

@ubcheema @aagarwalTT
Add gatekeeper to manage sockets.
e65b463 
    Add apis to Open/Connect datagram sockets.
    Add Socket sanity test.
@aagarwalTT aagarwalTT force-pushed the aagarwal/datagram-sockets branch from a46296a to eb08aca Compare January 17, 2025 19:49
@aagarwalTT aagarwalTT marked this pull request as ready for review January 17, 2025 19:50
@aagarwalTT aagarwalTT force-pushed the aagarwal/datagram-sockets branch from eb08aca to 457eebe Compare January 17, 2025 19:57
@aagarwalTT
Copy link
Contributor Author

aagarwalTT commented Jan 17, 2025 •
edited
Loading

The tests for sockets arent streamlined yet (due to re-prioritization). Will add the CI tests once we are done with stress testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliuTT aliuTT aliuTT approved these changes

@ubcheema ubcheema Awaiting requested review from ubcheema ubcheema is a code owner

@abhullar-tt abhullar-tt Awaiting requested review from abhullar-tt abhullar-tt is a code owner

@pgkeller pgkeller Awaiting requested review from pgkeller pgkeller is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@tt-dma tt-dma Awaiting requested review from tt-dma tt-dma is a code owner

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

@eelkozahTT eelkozahTT Awaiting requested review from eelkozahTT eelkozahTT is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aagarwalTT @aliuTT @ubcheema