Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#15796: Adding 1D tiled tensor support to reshape #16855

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

#15796: Adding 1D tiled tensor support to reshape #16855

wants to merge 5 commits into from
+4 −34

Conversation

jvegaTT
Copy link
Contributor

@jvegaTT jvegaTT commented Jan 17, 2025 •
edited
Loading

Ticket

#15796

Problem description

Adding support for 1D tensors

What's changed

APIs now support 1D tiled tensor creation so removing the bandaid
Move to simple shape removed the need for tiling reshape corrector
pytorch2 sweeps moved to 99.84% for data_movement.view.view_tt_torch, other reshape sweeps at 100%

Checklist

@jvegaTT jvegaTT marked this pull request as ready for review January 17, 2025 16:55
ntarafdar
ntarafdar reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@ntarafdar ntarafdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets fucking go!!

CC: @bbradelTT

@ntarafdar ntarafdar self-requested a review January 17, 2025 16:59
@jvegaTT
Copy link
Contributor Author

jvegaTT commented Jan 17, 2025

I just re-ran the commit tests as a couple new tests were just added. I will merge as soon as it completes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayerofieiev-tt ayerofieiev-tt ayerofieiev-tt approved these changes

@nardoTT nardoTT nardoTT approved these changes

@sminakov-tt sminakov-tt sminakov-tt approved these changes

@rfurko-tt rfurko-tt rfurko-tt approved these changes

@bbradelTT bbradelTT bbradelTT approved these changes

@sjameelTT sjameelTT sjameelTT approved these changes

@ntarafdar ntarafdar ntarafdar approved these changes

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

@jaykru-tt jaykru-tt Awaiting requested review from jaykru-tt jaykru-tt is a code owner

@yugi957 yugi957 Awaiting requested review from yugi957 yugi957 is a code owner

@llongTT llongTT Awaiting requested review from llongTT llongTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jvegaTT @ntarafdar @sjameelTT @bbradelTT @ayerofieiev-tt @rfurko-tt @sminakov-tt @nardoTT