Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added maybe_downcast & hardened TT Attrs and Types to include better support #1253

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Added maybe_downcast & hardened TT Attrs and Types to include better support #1253

merged 4 commits into from
Nov 15, 2024
+349 −107

Conversation

vprajapati-tt
Copy link
Contributor

  • Manually defined downcasting methods. Goal is to autogenerate these, should be decently easy to integrate with tblgen for the cpp methods, but difficult to throw into the pybind declaration itself. Was easier to do a short sighted fix where these methods are manually defined.
  • Used dyn_cast instead of cast for a safer call signature. Failure will be defined through the function resulting in None instead of a full failure.

@vprajapati-tt vprajapati-tt linked an issue Nov 13, 2024 that may be closed by this pull request
Implement maybe_downcast for TTMLIR Python Bindings #1246
Closed
@vprajapati-tt vprajapati-tt mentioned this pull request Nov 13, 2024
Closed
@vprajapati-tt vprajapati-tt removed a link to an issue Nov 13, 2024
Implement maybe_downcast for TTMLIR Python Bindings #1246
Closed
@vprajapati-tt vprajapati-tt linked an issue Nov 13, 2024 that may be closed by this pull request
Approach maybe_downcast TTMLIR Python Bindings in a manually defined manner. #1256
Closed
@nsmithtt
Copy link
Contributor

Vraj is this PR still relevant in light of the pybind macros we just discovered?

@vprajapati-tt
Copy link
Contributor Author

vprajapati-tt commented Nov 14, 2024 •
edited
Loading

Unfortunately no, my task for tomorrow is to refactor the python bindings to adopt this newer structure. I will close this PR and make a new one when that's ready. There are parts of this PR (the extended support for Attrs and Types in the TT, TTNN dialects) that will be transferred over to this new PR though.

@vprajapati-tt vprajapati-tt reopened this Nov 14, 2024
@vprajapati-tt vprajapati-tt removed a link to an issue Nov 14, 2024
Approach maybe_downcast TTMLIR Python Bindings in a manually defined manner. #1256
Closed
@vprajapati-tt vprajapati-tt linked an issue Nov 14, 2024 that may be closed by this pull request
Implement maybe_downcast for TTMLIR Python Bindings #1246
Closed
@vprajapati-tt vprajapati-tt self-assigned this Nov 14, 2024
@vprajapati-tt
Copy link
Contributor Author

@nsmithtt This PR is now relevant again 🎊. Feel free to review when available

nsmithtt
nsmithtt approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@nsmithtt nsmithtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, lgtm!

@vprajapati-tt vprajapati-tt merged commit 41323e9 into main Nov 15, 2024
18 checks passed
@vprajapati-tt vprajapati-tt deleted the vprajapati/issue-1246 branch November 15, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odjuricicTT odjuricicTT odjuricicTT approved these changes

@nsmithtt nsmithtt nsmithtt approved these changes

@tapspatel tapspatel Awaiting requested review from tapspatel tapspatel is a code owner

@nobradovictt nobradovictt Awaiting requested review from nobradovictt nobradovictt is a code owner

Assignees

@vprajapati-tt vprajapati-tt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement maybe_downcast for TTMLIR Python Bindings
3 participants
@vprajapati-tt @nsmithtt @odjuricicTT