Add clang-tidy PR comment bot #1269
Open
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmithtt
requested review from
vmilosevic,
tapspatel and
sdjordjevicTT
as code owners
tapspatel
approved these changes
Nov 14, 2024
| request_changes: false | ||
| # Optionally set the number of comments per review | ||
| # to avoid GitHub API timeouts for heavily loaded | ||
| # pull requests |
There was a problem hiding this comment.
thanks for these comments. These workflow files have magic functions so I really like you commenting what it's doing :)
There was a problem hiding this comment.
I copy pasted them so I can't take credit 😅
nsmithtt
force-pushed
the
nsmith/clang-tidy-comments
branch
2 times, most recently
from
4612656
to
607b12b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
include/ttmlir/Conversion/TTIRToTTIRDecomposition/TTIRToTTIRDecomposition.h
Outdated
Show resolved
Hide resolved
include/ttmlir/Conversion/TTIRToTTIRDecomposition/TTIRToTTIRDecomposition.h
Outdated
Show resolved
Hide resolved
include/ttmlir/Conversion/TTIRToTTIRDecomposition/TTIRToTTIRDecomposition.h
Outdated
Show resolved
Hide resolved
include/ttmlir/Conversion/TTIRToTTIRDecomposition/TTIRToTTIRDecomposition.h
Outdated
Show resolved
Hide resolved
include/ttmlir/Conversion/TTIRToTTIRDecomposition/TTIRToTTIRDecomposition.h
Outdated
Show resolved
Hide resolved
include/ttmlir/Conversion/TTIRToTTIRDecomposition/TTIRToTTIRDecomposition.h
Outdated
Show resolved
Hide resolved
include/ttmlir/Conversion/TTIRToTTIRDecomposition/TTIRToTTIRDecomposition.h
Outdated
Show resolved
Hide resolved
nsmithtt
force-pushed
the
nsmith/clang-tidy-comments
branch
from
3323558
to
d0742d1
Compare
nsmithtt
requested review from
svuckovicTT,
mtopalovicTT,
rpavlovicTT,
nobradovictt and
jserbedzijaTT
as code owners
nobradovictt
approved these changes
Nov 15, 2024
| @@ -2,8 +2,8 @@ | |||
| // | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| #ifndef TTMLIR_DIALECT_TTNN_TRANSFORMS_OPTIMIZER_H | |||
| #define TTMLIR_DIALECT_TTNN_TRANSFORMS_OPTIMIZER_H | |||
| #ifndef TTMLIR_DIALECT_TTNN_TRANSFORMS_OPTIMIZE_H | |||
There was a problem hiding this comment.
Wait for the bot! :)
Comment on lines
5
to
6
| #ifndef TTMLIR_DIALECT_TTNN_TRANSFORMS_OPTIMIZE_H | ||
| #define TTMLIR_DIALECT_TTNN_TRANSFORMS_OPTIMIZE_H |
There was a problem hiding this comment.
header guard does not follow preferred style
Suggested change
| #ifndef TTMLIR_DIALECT_TTNN_TRANSFORMS_OPTIMIZE_H | |
| #define TTMLIR_DIALECT_TTNN_TRANSFORMS_OPTIMIZE_H | |
| #ifndef TTMLIR_DIALECT_TTNN_TRANSFORMS_OPTIMIZER_H | |
| #define TTMLIR_DIALECT_TTNN_TRANSFORMS_OPTIMIZER_H |
There was a problem hiding this comment.
Now just to figure out why it's commenting multiple times for the same thing 😅
There was a problem hiding this comment.
Maybe to make sure you cant miss it? :D
There was a problem hiding this comment.
- you made a mistake
- you made a mistake
- you made a mistake
- you made a mistake
- you made a mistake
- you made a mistake
- you made a mistake
nsmithtt
force-pushed
the
nsmith/clang-tidy-comments
branch
from
d0742d1
to
8f68bb3
Compare
nsmithtt
force-pushed
the
nsmith/clang-tidy-comments
branch
from
8f68bb3
to
7685caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.