Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose stablehlo transpose into multiple ttir.transpose ops #1273

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

LPanosTT
Copy link
Contributor

@LPanosTT LPanosTT commented Nov 14, 2024

The scope of stablehlo.transpose includes general permutation which is equivalent to multiple dimension swaps. These changes to stablehlo -> TTIR conversion allows the decomposition of stablehlo.transpose into however many ttir.transpose ops are required to perform the desired permutation.

@LPanosTT LPanosTT force-pushed the lpanos/shlo_transpose branch 2 times, most recently from 7b6236a to 8a4f1f3 Compare November 15, 2024 14:04
@mmanzoorTT
Copy link
Contributor

mmanzoorTT commented Nov 15, 2024

TTNN is supporting transpose op for higher dimensions with recent tt-metal uplift. PR #1288 uses ttnn.transpose instead of decomposing it to permutation in runtime. May be we should follow the same and lower stablehlo.transpose to ttir.transpose.

@LPanosTT
Copy link
Contributor Author

TTNN is supporting transpose op for higher dimensions with recent tt-metal uplift. PR #1288 uses ttnn.transpose instead of decomposing it to permutation. May be we should follow the same and lower stablehlo.transpose to ttir.transpose

It looks like they are just making a runtime change to use ttnn::transpose in runtime instead of using a single swap permute.

@LPanosTT LPanosTT merged commit 4e8207f into main Nov 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants