Fix clang-tidy errors, closes #189 #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmithtt
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic,
sdjordjevicTT,
rpavlovicTT,
mrakitaTT,
nobradovictt,
rjakovljevicTT and
vmilosevic
as code owners
nsmithtt
commented
Sep 2, 2024
runtime/lib/ttnn/program.cpp
Outdated
| TT_FATAL(isOnHost(inputTensor) or isOnDevice(inputTensor), | ||
| "Unsupported storage type {}", inputTensor.storage_type()); | ||
| assert((isOnHost(inputTensor) or isOnDevice(inputTensor)) && | ||
| "Unsupported storage type"); |
There was a problem hiding this comment.
@jnie-TT, unfortunately we cannot use TT_FATAL, we just happened to pull in metal's assert.hpp, but this is not public API.
There was a problem hiding this comment.
Sounds good... Thanks for updating this!
| @@ -131,11 +131,10 @@ mlir::tt::SystemDescAttr::getFromPath(MLIRContext *context, std::string &path) { | |||
|
|
|||
| // Acquire chip descs | |||
| std::vector<tt::ChipDescAttr> chip_desc_list; | |||
| for (auto element : *binary_chip_desc) { | |||
|
|
|||
| for (auto const *element : *binary_chip_desc) { | |||
There was a problem hiding this comment.
clang-tidy suggests all uses of auto are at least qualified with specifiers.
nsmithtt
force-pushed
the
nsmith/lint
branch
from
98643a6
to
279c431
Compare
jnie-TT
approved these changes
Sep 3, 2024
nobradovictt
approved these changes
Sep 3, 2024
sdjordjevicTT
approved these changes
Sep 3, 2024
nsmithtt
force-pushed
the
nsmith/lint
branch
2 times, most recently
from
b95081e
to
58f8177
Compare
AleksKnezevic
approved these changes
Sep 3, 2024
nsmithtt
force-pushed
the
nsmith/lint
branch
5 times, most recently
from
0b08397
to
cce8a5b
Compare
nsmithtt
force-pushed
the
nsmith/lint
branch
from
cce8a5b
to
305ab41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.