Initial implementation for simple scheduler #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odjuricicTT
reviewed
Sep 3, 2024
Is this related to 6AM moment? |
nobradovictt
requested changes
Sep 3, 2024
odjuricicTT
reviewed
Sep 5, 2024
| dependencies(scheduler.dependencies) {} | ||
|
|
||
| llvm::SmallVector<mlir::Operation *> Scheduler::getScheduleableOps() { | ||
| llvm::SmallVector<mlir::Operation *> scheduleableOps; |
There was a problem hiding this comment.
Nit: You could also keep this as part of Scheduler state in order to avoid iterating over all unscheduled ops. Might be a premature optimization tho.
There was a problem hiding this comment.
I had that implementation for pybuda scheduler. I didn't like it it wasn't readable. If it proves that this is too slow we can change
| Scheduler::Scheduler(func::FuncOp *func) { | ||
| for (auto &op : func->getOps()) { | ||
| if (isTTIROp(&op) && isDpsOp(&op)) { | ||
| dependencies[&op] = {}; |
There was a problem hiding this comment.
Is it possible to use op->getOperands() instead of having dependencies as part of scheduler state?
nobradovictt
approved these changes
Sep 5, 2024
* Scheduler assumes that input is `FuncOp` which contains single `FuncOp` * Scheduler constructs dependency graph using TTIR ops. * This excludes ops like `ttnn.open_device`, `ttnn.close_device`, we need to find some way how to handle them i.e either scheduler puts them at the start/end of schedule or we handle them in some different way. * Snapshotting creates deep copy of scheduler members * Tested by creating pass which printed dependency graph of some more complex graph that was handcrafted (didn't include pass nor test code in PR but I can do if needed).
mtopalovicTT
force-pushed
the
milant/add_scheduler
branch
from
d300d4c
to
efca59d
Compare
vmilosevic
approved these changes
Sep 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModuleOpwhich contains singleFuncOpttnn.open_device,ttnn.close_device, we need to find some way how to handle them i.e either scheduler puts them at the start/end of schedule or we handle them in some different way.closes #571