runtime support for full op #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnie-TT
force-pushed
the
jnie/full_op
branch
from
a0ff1bc
to
cd99680
Compare
nsmithtt
approved these changes
Sep 8, 2024
| auto shape = ::ttnn::Shape(::tt::tt_metal::Shape( | ||
| utils::toShapeFromFBShape(*op->out()->desc()->shape()))); | ||
| float fillValue = op->fill_value(); | ||
| // TODO(bug #272), determine correct layout by tile shape in the future |
There was a problem hiding this comment.
For now we can probably assert that there are only 2 tile shapes and therefore infer, [1, 1] -> row major, or [32, 32] -> tiled
There was a problem hiding this comment.
Confirmed with @nsmithtt @nobradovictt that currently we don't have compiler support for dynamically generating tile shapes, will leave this hardcoded and TODO for now until we bring up the support.
jnie-TT
force-pushed
the
jnie/full_op
branch
2 times, most recently
from
c9f9d56
to
0401c3a
Compare
jnie-TT
force-pushed
the
jnie/full_op
branch
from
0401c3a
to
4e806c6
Compare
uazizTT
pushed a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #626