Skip to content

Commit

Permalink
Update default node version to 22
Browse files Browse the repository at this point in the history
  • Loading branch information
busma13 committed Sep 25, 2024
1 parent 2f1f453 commit b08a4de
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/publish-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand All @@ -60,7 +60,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ on:
branches: [ master ]
env:
NODE_VERSIONS: '[18, 20, 22]'
NODE_VERSION_MAIN: '18'
NODE_VERSION_MAIN: '22'
NODE_VERSIONS_K8S: '[18, 22]'
NODE_VERSIONS_EXT_STORAGE: '[18]'
NODE_VERSIONS_EXT_STORAGE: '[22]'

jobs:
compute-node-version-vars:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# NODE_VERSION is set by default in the config.ts, the following value will only
# be used if you build images by default with docker build
ARG NODE_VERSION=18
ARG NODE_VERSION=22
FROM ghcr.io/terascope/node-base:${NODE_VERSION}

ARG TERASLICE_VERSION
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# NODE_VERSION is set by default in the config.ts, the following value will only
# be used if you build images by default with docker build
ARG NODE_VERSION=18
ARG NODE_VERSION=22
FROM ghcr.io/terascope/node-base:${NODE_VERSION}

ENV NODE_ENV production
Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/src/helpers/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ if (testElasticsearch) {
export const SEARCH_TEST_HOST = testHost;

export const TEST_NODE_VERSIONS = ['18', '20', '22'];
export const DEFAULT_NODE_VERSION = '18';
export const DEFAULT_NODE_VERSION = '22';
// This overrides the value in the Dockerfile
export const NODE_VERSION = process.env.NODE_VERSION || DEFAULT_NODE_VERSION;

Expand Down
2 changes: 1 addition & 1 deletion packages/teraslice-cli/src/helpers/asset-src.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class AssetSrc {
devMode = false,
debug = false,
bundle = true,
bundleTarget = 'node18',
bundleTarget = 'node22',
overwrite = false
) {
if (bundle === false) {
Expand Down

0 comments on commit b08a4de

Please sign in to comment.