Skip to content

Commit

Permalink
[scripts] Update default minio tag to RELEASE.2024-08-29T01-40-52Z (#…
Browse files Browse the repository at this point in the history
…3744)

This PR makes the following changes:

- Changes the default minio tag in scripts from
`RELEASE.2022-09-22T18-57-27Z` to `RELEASE.2024-08-29T01-40-52Z`
- Fixes bug in `S3store` where verifying the client will fail in newer
versions of minio
- Bumps **@terascope/scripts** from `v1.1.0` to `v1.1.1`

Ref to issue #3742
  • Loading branch information
sotojn authored Sep 18, 2024
1 parent f9a8f73 commit cda833b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/scripts/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@terascope/scripts",
"displayName": "Scripts",
"version": "1.1.0",
"version": "1.1.1",
"description": "A collection of terascope monorepo scripts",
"homepage": "https://github.com/terascope/teraslice/tree/master/packages/scripts#readme",
"bugs": {
Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/src/helpers/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const MINIO_HOSTNAME = process.env.MINIO_HOSTNAME || HOST_IP;
export const MINIO_PORT = process.env.MINIO_PORT || '49000';
export const ENCRYPT_MINIO = toBoolean(process.env.ENCRYPT_MINIO ?? false);
export const MINIO_HOST = `http${ENCRYPT_MINIO ? 's' : ''}://${MINIO_HOSTNAME}:${MINIO_PORT}`;
export const MINIO_VERSION = process.env.MINIO_VERSION || 'RELEASE.2022-09-22T18-57-27Z';
export const MINIO_VERSION = process.env.MINIO_VERSION || 'RELEASE.2024-08-29T01-40-52Z';
export const MINIO_DOCKER_IMAGE = process.env.MINIO_DOCKER_IMAGE || 'minio/minio';
export const MINIO_ACCESS_KEY = process.env.MINIO_ACCESS_KEY || 'minioadmin';
export const MINIO_SECRET_KEY = process.env.MINIO_SECRET_KEY || 'minioadmin';
Expand Down
3 changes: 1 addition & 2 deletions packages/teraslice/src/lib/storage/backends/s3_store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,7 @@ export class S3Store {
if (this.isShuttingDown) return false;

const command = {
Bucket: this.bucket,
MaxKeys: 0
Bucket: this.bucket
};
const config = this.terafoundation.connectors.s3[this.connection];
try {
Expand Down

0 comments on commit cda833b

Please sign in to comment.