Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Node 22 as default version #3771

Closed
busma13 opened this issue Sep 25, 2024 · 2 comments
Closed

Set Node 22 as default version #3771

busma13 opened this issue Sep 25, 2024 · 2 comments
Assignees
@busma13

Comments

@busma13
Copy link
Contributor

busma13 commented Sep 25, 2024 •
edited
Loading

Node 22 has been tested for quite some time, but now we want to set it as the default.

Places where there is a default node version:

  • test.yml - used by verify-build, lint-and-sync , and e2e-external-storage-tests jobs
  • publish-master.yml
  • publish-tag.yml
  • Dockerfile and Dockerfile.dev
  • scripts config.ts
  • teraslice-cli asset-src.ts

@types/node should be moved to 22, but the node engines setting should stay at 18
@busma13 busma13 self-assigned this Sep 25, 2024
@busma13 busma13 mentioned this issue Sep 25, 2024
Merged
godber pushed a commit that referenced this issue Sep 30, 2024
@busma13
[workspace, scripts, teraslice-cli] Update default node version to 22 (…
8c934f0 
…#3773)

This PR makes the following changes:
- `test.yml` - set `NODE_VERSION_MAIN` and `NODE_VERSION_EXT_STORAGE` to
22 (used by verify-build, lint-and-sync , and e2e-external-storage-tests
jobs)
- `publish-master.yml` - node-version to 22
- `publish-tag.yml` - node-version to 22
- `Dockerfile` and `Dockerfile.dev` - NODE_VERSION to 22
- scripts `config.ts` - DEFAULT_NODE_VERSION to 22
- teraslice-cli `asset-src.ts` - bundleTarget defaults to node22

ref: #3771
@godber
Copy link
Member

godber commented Oct 1, 2024

#3773 probably closed this issue yeah?

@busma13
Copy link
Contributor Author

busma13 commented Oct 1, 2024

yes

@busma13 busma13 closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busma13 busma13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@godber @busma13