Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace, scripts, teraslice-cli] Update default node version to 22 #3773

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Sep 25, 2024

This PR makes the following changes:

  • test.yml - set NODE_VERSION_MAIN and NODE_VERSION_EXT_STORAGE to 22 (used by verify-build, lint-and-sync , and e2e-external-storage-tests jobs)
  • publish-master.yml - node-version to 22
  • publish-tag.yml - node-version to 22
  • Dockerfile and Dockerfile.dev - NODE_VERSION to 22
  • scripts config.ts - DEFAULT_NODE_VERSION to 22
  • teraslice-cli asset-src.ts - bundleTarget defaults to node22

ref: #3771

@busma13 busma13 self-assigned this Sep 25, 2024
@busma13 busma13 changed the title [workspace] Update default node version to 22 [workspace, scripts, teraslice-cli] Update default node version to 22 Sep 25, 2024
@godber
Copy link
Member

godber commented Sep 25, 2024

Do we have documentation on how to do this upgrade if not, add them, if so, are they up to date?

@busma13
Copy link
Contributor Author

busma13 commented Sep 26, 2024

Not that I can find, I will add a section to the development area in the docs.

@busma13
Copy link
Contributor Author

busma13 commented Sep 26, 2024

Oh wait, I found them, they just aren't linked properly on the website. I'll fix that and update them if needed.

@godber godber added this to the Teraslice 2.5.0 milestone Sep 27, 2024
@busma13 busma13 force-pushed the node-22-main-version branch from 92be4ae to 7f5434b Compare September 30, 2024 22:36
@busma13 busma13 marked this pull request as ready for review September 30, 2024 23:08
@busma13 busma13 requested review from godber and sotojn September 30, 2024 23:08
@godber godber merged commit 8c934f0 into master Sep 30, 2024
68 checks passed
@godber godber deleted the node-22-main-version branch September 30, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants