[teraslice] - Add ability to soft delete a job #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
ciorg
reviewed
Aug 10, 2024
jsnoble
requested changes
Aug 23, 2024
busma13
force-pushed
the
job-deletion
branch
from
ba9e2b9 to
e06dd26
Compare
busma13
commented
Sep 3, 2024
busma13
commented
Sep 3, 2024
busma13
force-pushed
the
job-deletion
branch
from
208d26e to
2db646a
Compare
bump: (minor) [email protected], [email protected] bump: (minor) @terascope/[email protected], @terascope/[email protected] bump: (minor) @terascope/[email protected], @terascope/[email protected] bump: (minor) [email protected], [email protected] bump: (minor) [email protected], [email protected] bump: (minor) [email protected], @terascope/[email protected]
busma13
changed the title
godber
requested changes
Sep 5, 2024
e2e/test/cases/cluster/api-spec.ts
Outdated
| await terasliceHarness.teraslice.jobs.post(`/jobs/${jobId}/_stop`); | ||
| await terasliceHarness.waitForExStatus(ex, 'stopped', 100, 1000); | ||
|
|
||
| await expect(terasliceHarness.teraslice.jobs.delete(`/jobs/${jobId}`)).resolves.toMatchObject(deletedJobProperties); |
There was a problem hiding this comment.
At this point, the job should not show up in /txt/jobs, if there's an easy way to test that, it might be worth doing.
You can test any of the scenarios that being deleted causes, like no updating or starting.
| @@ -563,6 +572,33 @@ $ curl 'localhost:5678/v1/jobs/5a50580c-4a50-48d9-80f8-ac70a00f3dbd/errors' | |||
| ] | |||
| ``` | |||
|
|
|||
| ## DELETE /v1/jobs/\{jobId\}; | |||
|
|
|||
| Issues a delete command, deleting the job and all related execution contexts. Any orphaned K8s resources associated with the job will also be deleted. The job must have a terminal status to be deleted. The `active` field will automatically be set to `false`. | |||
There was a problem hiding this comment.
Please extend this with the consequences of deleting a job:
A delete job cannot be updated ....
godber
approved these changes
Sep 6, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
v1routes.delete('/jobs/:jobId')endpointjobsServiceto throw when trying to start, update, or recover a deleted job/jobs,/txt/jobs,/ex, and/txt/exendpoints to filter bydeletedteraslice-cli jobs deleteandteraslice-cli tjm deletecommands and necessary helper functions.teraslice-cli jobs listto adddeletedandactiveflagsteraslice-cli jobs exto adddeletedflagteraslice-cli helpers.tsandteraslice-client-js Jobs.list() to removestatus` query. Status inside a job was removed in job refactor #303. Fix Jobs.list in teraslice-client-js and remove jobs method #880 may also be relevant.ref: #3680