[teraslice] add typescript types to KubernetesV2 backend #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godber
approved these changes
Oct 31, 2024
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetesV2/k8s.ts
Outdated
Show resolved
Hide resolved
godber
changed the title
jsnoble
reviewed
Nov 1, 2024
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetesV2/index.ts
Outdated
Show resolved
Hide resolved
jsnoble
reviewed
Nov 1, 2024
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetesV2/k8sResource.ts
Outdated
Show resolved
Hide resolved
jsnoble
reviewed
Nov 1, 2024
packages/teraslice/test/lib/cluster/services/cluster/backends/kubernetes/v2/k8s-v2-spec.ts
Outdated
Show resolved
Hide resolved
jsnoble
reviewed
Nov 1, 2024
...es/teraslice/test/lib/cluster/services/cluster/backends/kubernetes/v2/k8sResource-v2-spec.ts
Outdated
Show resolved
Hide resolved
busma13
commented
Nov 6, 2024
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetesV2/k8s.ts
Outdated
Show resolved
Hide resolved
busma13
commented
Nov 6, 2024
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetesV2/utils.ts
Outdated
Show resolved
Hide resolved
busma13
commented
Nov 6, 2024
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetesV2/utils.ts
Outdated
Show resolved
Hide resolved
jsnoble
reviewed
Nov 7, 2024
| @@ -2,6 +2,10 @@ | |||
| // output for nock | |||
| // env DEBUG='nock*' make test | |||
There was a problem hiding this comment.
That got copied over from kubernetes v1. I'll get rid of it.
jsnoble
reviewed
Nov 7, 2024
| @@ -174,6 +174,7 @@ export class TestContext implements i.Context { | |||
| analytics: 'yearly', | |||
| state: 'montly', | |||
| }, | |||
| kubernetes_api_poll_delay: 1000, | |||
There was a problem hiding this comment.
Is this the only kubernetes config or are there other ones as well?
jsnoble
reviewed
Nov 7, 2024
packages/types/src/teraslice.ts
Outdated
| @@ -480,7 +480,7 @@ export interface Config { | |||
| execution_controller_targets?: ExecutionControllerTargets[]; | |||
| hostname: string; | |||
| index_rollover_frequency: IndexRolloverFrequency; | |||
| kubernetes_api_poll_delay?: number | 1000; | |||
| kubernetes_api_poll_delay: number | 1000; | |||
There was a problem hiding this comment.
so there seems to be a mistake, there should be no numbers at all in interface Config, also, the other kubernetes config values, are they really optional? Or do they have a real default setting that should be manifested in the types?
bump: (minor) @terascope/[email protected], @terascope/[email protected] bump: (minor) [email protected], [email protected] bump: (minor) [email protected], [email protected] bump: (minor) [email protected], @terascope/[email protected] bump: (minor) @terascope/[email protected], @terascope/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
kubernetesV2backendK8sResourcean abstract class and addK8sJobResource,K8sServiceResource, andK8sDeploymentResourceclasses. This makes creating resources from templates cleaner.K8sResourcetypes asTSResourcetypes with all required fields defined.