[scripts] k8s-env automatically switches to es7 on Arm Macs #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
reviewed
Nov 15, 2024
Comment on lines
+846
to
+854
| // Check for arm architecture and es6 combo, if so switch to es7 | ||
| if ( | ||
| service === 'elasticsearch' | ||
| && os.arch().includes('arm') | ||
| && version.startsWith('6') | ||
| ) { | ||
| signale.warn('Detected arm architecture with unsupported es6, switching to es7.9.3..'); | ||
| version = '7.9.3'; | ||
| } |
There was a problem hiding this comment.
Can we do this outside of this if statement so it works for docker as well?
Comment on lines
+634
to
+635
| && options.testPlatform.includes('kubernetes')) | ||
| ) { |
There was a problem hiding this comment.
If we do this for docker too this check isn't needed.
|
We've decided to instead change the default version of es 6 to es 7 so that we can have cross compatibility between arm and amd users. #3833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Scripts
New features
k8s-envcommand that checks the host system’s architecture and the Elasticsearch version. If the host architecture matches ARM and the Elasticsearch version is 6.x,k8s-envwill automatically switch the Elasticsearch version to7.9.3to ensure compatibility.Bumps
v1.5.0tov1.5.1