Update to yarn 4 #3887
Merged
Update to yarn 4 #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sotojn
force-pushed
the
yarn-4-upgrade
branch
2 times, most recently
from
e03ea7e to
9ce84a7
Compare
bump: (patch) [email protected], [email protected] bump: (patch) @terascope/[email protected], @terascope/[email protected] bump: (patch) @terascope/[email protected], @terascope/[email protected] bump: (patch) @terascope/[email protected], @terascope/[email protected] bump: (patch) [email protected], @terascope/[email protected]
bump: (minor) [email protected]
|
LGTM i was able to pull & get yarn 4 instead of 1 with the yarn path fix, maybe @jsnoble could review too though since more familiar w/teraslice then me |
lesleydreyer
reviewed
Jan 9, 2025
godber
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
There are some recommendations in here, but probably not worth pushing a new commit for. I think these changes aren't really all that bad, and mostly the cost of switching to a new version of yarn. I don't think they'd set us back much if we went to something else either.
| @@ -46,6 +45,7 @@ | |||
| "resolutions": { | |||
| "@types/lodash": "~4.17.13", | |||
| "debug": "~4.4.0", | |||
| "jest-config": "patch:jest-config@npm%3A29.7.0#~/.yarn/patches/jest-config-npm-29.7.0-97d8544d74.patch", | |||
There was a problem hiding this comment.
There should be a comment explaining why this patch is here ... or that should be documented somewhere.
busma13
pushed a commit
that referenced
this pull request
Jan 10, 2025
This PR makes the following changes: ## Changes - Updates `teraslice` repo from yarn `v1.22.19` to yarn `v4.6.0` - Updates `website` repo form yarn `v1.22.19` to yarn `v4.6.0` - Updates `teraslice-cli` test assets fixture repo to be compliant with yarn 4 - Updates all `package.json` test scripts in the packages directory to be compliant with yarn 4's explicit dependency scope restrictions - In this case, `@teraslice/scripts` was only a dependency at the top-level, which is caused all `workspaces` that doesn't have `@teraslice/scripts` to not find the scripts binary within it's directory. - Yarn 1 had a loose dependency resolution algorithm where yarn 4 enforces explicit dependencies. - https://yarnpkg.com/blog/release/4.0#javascript-constraints ## Bumped Packages - release: (**minor**) **[email protected]** - bump: (**minor**) **[email protected]** - bump: (patch) **@terascope/[email protected]** - bump: (patch) **[email protected]** - bump: (patch) **[email protected]** - bump: (patch) **[email protected]** - bump: (patch) **@terascope/[email protected]** - bump: (patch) **@terascope/[email protected]** - bump: (patch) **@terascope/[email protected]** - bump: (patch) **@terascope/[email protected]** - bump: (patch) **@terascope/[email protected]** - bump: (patch) **@terascope/[email protected]** - bump: (patch) **[email protected]** - bump: (patch) **@terascope/[email protected]**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Changes
teraslicerepo from yarnv1.22.19to yarnv4.6.0websiterepo form yarnv1.22.19to yarnv4.6.0teraslice-clitest assets fixture repo to be compliant with yarn 4package.jsontest scripts in the packages directory to be compliant with yarn 4's explicit dependency scope restrictions@teraslice/scriptswas only a dependency at the top-level, which is caused allworkspacesthat doesn't have@teraslice/scriptsto not find the scripts binary within it's directory.Bumped Packages