login: fix argument escaping

termux · Oct 20, 2024 · b8e94ca · b8e94ca
1 parent 84719e4
commit b8e94ca
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/proot-distro.sh b/proot-distro.sh
@@ -1643,15 +1643,10 @@ command_login() {
 		set -u
 	done
 	unset var
-
-	local -a login_shell_args
+
 	if [ $# -ge 1 ]; then
-		# Wrap in quotes each argument to prevent word splitting.
-		local -a login_shell_args
-		for i in "$@"; do
-			login_shell_args+=("'$i'")
-		done
-		set -- "-c" "${login_shell_args[*]}"
+		# Escape each argument to prevent word splitting.
+		set -- "-c" "$(printf " %q" "$@")"
 	else
 		set --
 	fi